Skip to content

Add lift scalar to constant tensor pass#8313

Closed
cccclai wants to merge 1 commit intopytorch:mainfrom
cccclai:export-D69318149
Closed

Add lift scalar to constant tensor pass#8313
cccclai wants to merge 1 commit intopytorch:mainfrom
cccclai:export-D69318149

Conversation

@cccclai
Copy link
Copy Markdown
Contributor

@cccclai cccclai commented Feb 7, 2025 •
edited
Loading

Differential Revision: D69318149

Sometime the op in the graph will receive a scalar input, and quantization can only deal with tensor. In this case, the recommended workflow is to lift the scalar constant to be a tensor, and annotate them, then these constants will have corresponding q/dq nodes.

This PR is mostly a demonstration regarding where to insert the pass and how the pass should look like

@cccclai @facebook-github-bot
Add lift scalar to constant tensor pass
71eb924 
Differential Revision: D69318149
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8313

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 71eb924 with merge base 77f18b2 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 7, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 7, 2025

This pull request was exported from Phabricator. Differential Revision: D69318149

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 7, 2025

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@cccclai cccclai marked this pull request as draft February 7, 2025 19:31
haowhsu-quic
haowhsu-quic reviewed Feb 10, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@haowhsu-quic haowhsu-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super helpful for us instead of tackling constant inside op builder. Will try make it more general and do some clean up jobs in codebase.
Thank you for this PR.

This was referenced Feb 11, 2025
Open
Open
@chunit-quic chunit-quic mentioned this pull request Feb 24, 2025
Merged
This was referenced Feb 24, 2025
Open
Open
@cccclai
Copy link
Copy Markdown
Contributor Author

cccclai commented Mar 17, 2025

#8642 is merged instead

@cccclai cccclai closed this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunit-quic chunit-quic Awaiting requested review from chunit-quic

@shewu-quic shewu-quic Awaiting requested review from shewu-quic

@winskuo-quic winskuo-quic Awaiting requested review from winskuo-quic

@abhinaykukkadapu abhinaykukkadapu Awaiting requested review from abhinaykukkadapu abhinaykukkadapu will be requested when the pull request is marked ready for review abhinaykukkadapu is a code owner

1 more reviewer

@haowhsu-quic haowhsu-quic haowhsu-quic left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cccclai @facebook-github-bot @haowhsu-quic